[ZEP-13] corrige le comportement d'Elasticsearch #4262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre-24
changed the title
pierre-24
changed the title
artragis
requested changes
Apr 2, 2017
| @@ -30,6 +30,11 @@ <h3 class="content-title" itemprop="itemListElement"> | |||
| {% trans "Article publié" %} | |||
| {% elif search_result.content_type == 'TUTORIAL' %} | |||
| {% trans "Tutoriel publié" %} | |||
| {% elif search_result.content_type == 'OPINION' %} | |||
| {% trans "Opinion" %} | |||
There was a problem hiding this comment.
Le mot de base, c'est "Billiet".
| {% elif search_result.content_type == 'OPINION' %} | ||
| {% trans "Opinion" %} | ||
| {% if search_result.picked %} | ||
| {% trans "mise en avant" %} |
| index_manager.delete_document(instance) | ||
| index_manager.refresh_index() | ||
|
|
||
| if index_manager.index_exists: |
There was a problem hiding this comment.
vue la répétition de ces trois lignes, créer une méthode delete_and_refresh peut être utile non?
|
|
||
|
|
||
| def get_django_indexable_objects(): | ||
| """Return all indexable objects registered in Django""" | ||
| return [model for model in apps.get_models() if issubclass(model, AbstractESDjangoIndexable)] | ||
|
|
||
|
|
||
| class NeedIndex(Exception): |
There was a problem hiding this comment.
Juste ajouter une petite docstring pour faire beau dans la doc :)
| 'filter': Match(content_type='ARTICLE'), | ||
| 'weight': settings.ZDS_APP['search']['boosts']['publishedcontent']['if_article'] | ||
| }, | ||
| { | ||
| 'filter': Match(content_type='OPINION'), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA
Cette QA nécessite Elasticsearch (mais je rappelle que c'est très facile à installer ;) ).
make index-all). Faire une recherche sur le mot "banane" et vérifier que la tribune apparait bien.make index-flagged). Faire une recherche sur le mot "banane" et vérifier que tout y est (deux tribunes et un article). Vérifier que l'article apparait bien premier.make index-flagged). Faire une recherche sur le mot "banane" et vérifier que "banane jaune" apparait bien en second.make index-flagged). Faire une recherche sur le mot "banane" et vérifier que "banane jaune" apparait bien en troisième.