Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrige la façon de récupérer la version de nvm #6688

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

philippemilink
Copy link
Member

Avec le commentaire dans le fichier .nvmrc, le script d'installation affichait :

% ./scripts/install_zds.sh +node
* [+node] installing nvm (v0.39.5) & node (v18
# needs to be also updated in .github/workflows/ci.yml) & yarn

Contrôle qualité

Exécuter :

./scripts/install_zds.sh +node

et constater que le message affiché n'est pas bizarre.

@coveralls
Copy link

coveralls commented Nov 17, 2024

Coverage Status

coverage: 89.2%. remained the same
when pulling 4e81928 on philippemilink:fix-install-message
into b39c7fc on zestedesavoir:dev.

@philippemilink philippemilink added the C-DevelopmentEnv Amélioration de l'environnement de dev label Nov 17, 2024
Avec le commentaire dans le fichier .nvmrc, le script d'installation
affichait :
```
% ./scripts/install_zds.sh +node
* [+node] installing nvm (v0.39.5) & node (v18
# needs to be also updated in .github/workflows/ci.yml) & yarn
```
Copy link
Contributor

@Arnaud-D Arnaud-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ✔️

@Arnaud-D Arnaud-D enabled auto-merge (squash) December 25, 2024 08:38
@Arnaud-D Arnaud-D merged commit 4d9a460 into zestedesavoir:dev Dec 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-DevelopmentEnv Amélioration de l'environnement de dev
Projects
Status: Fusionnée
Development

Successfully merging this pull request may close these issues.

3 participants