Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark-abbr to tests and re-record snapshots #515

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

richardTowers
Copy link

The only difference in the snapshots seems to be the presence of \\ backslashes before quote characters.

I'm a little confused by the output, not being all that familiar with jest, but I suspect this is some minor difference in the way that rehype-stringify works and that we don't need to worry about it?

This is just laying a small bit of groundwork, before I attempt to get remark-abbr working with the new version of remark

See also #514

StaloneLab and others added 2 commits August 2, 2024 16:58
The only difference in the snapshots seems to be the presence of `\\`
backslashes before quote characters. I'm a little confused by the
output, not being all that familiar with jest, but I suspect this is
some minor difference in the way that rehype-stringify works and that we
don't need to worry about it?
@StaloneLab
Copy link
Member

I'm way too surprised that the tests work (apart from these backslashes, I'll check). It seems that actually the plugin might work out of the box on new remark versions: it relies only on unist-util-visit which operates only on AST and does not require anything special. I think you would have noticed if it was the case, what am I missing? Or maybe you wanted to use the low-level micromark API?

@StaloneLab
Copy link
Member

Hum I see unrelated linting problems, I fixed on next, you should be able to rebase (I forced push so maybe cherry-pick is easier). On top of that, there are some other changes to be done which we do while transitioning to next. I think the easiest way is to merge and I'll do the changes right after. They are stupid changes anyway, purely workflow, not really relevant to what you are trying to achieve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants