Reimplemented alt error prioritisation, added more recovery strategies #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last really big thing that needed implementing for
zero-copy
.I was really worried that implementing it would hurt our benchmarks a lot since a very substantial proportion of the work that happens on
master
is related to error prioritisation.However, I did some thinking and came to the conclusion that, for the most part, we can treat the returned error of a parser and the alt error as the same thing, massively simplifying its implementation and speeding things up a lot.
On the JSON benchmark, we only lose about ~7% with this change, still placing us waaay ahead of
nom
and friends. We pretty much regain the same high-quality error generation capabilities as are present onmaster
, while also simplifying the implementation of parsers, for the most part.