Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplemented alt error prioritisation, added more recovery strategies #304

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

zesterer
Copy link
Owner

@zesterer zesterer commented Feb 28, 2023

This is the last really big thing that needed implementing for zero-copy.

I was really worried that implementing it would hurt our benchmarks a lot since a very substantial proportion of the work that happens on master is related to error prioritisation.

However, I did some thinking and came to the conclusion that, for the most part, we can treat the returned error of a parser and the alt error as the same thing, massively simplifying its implementation and speeding things up a lot.

On the JSON benchmark, we only lose about ~7% with this change, still placing us waaay ahead of nom and friends. We pretty much regain the same high-quality error generation capabilities as are present on master, while also simplifying the implementation of parsers, for the most part.

@zesterer zesterer changed the base branch from master to zero-copy February 28, 2023 17:40
@zesterer zesterer merged commit 4324d7c into zero-copy Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant