Add spinlock implementation without std::thread::sleep
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zesterer
requested changes
Jul 27, 2024
|
Great, thanks for the PR! |
|
?? |
2 tasks
|
maybe a ci wasm build check would be nice? to guarantee that doesn't break again |
|
@zesterer ?? |
|
Sorry about that. I replied, ran CI, then didn't get back to this. Anyhow, much appreciated! |
|
Tysm!! Would it be possible to get this published on crates.io as well? |
|
@zesterer I'm sorry for constantly pinging you- but it seems to be the only way to get your attention? |
|
I should have some free time tomorrow to do this, thanks for the reminder. |
|
Not forgotten about this, trying to find the time to write up what turns out to be quite an extensive changelog! |
|
take your time, we appreciate your efforts :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds aspin-plainfeature that uses a spinlock-based locking system like thespinfeature does, but without usingstd::thread::sleep. Closes #137.Edit: This pull request changes the
spinfeature to only usestd::thread::sleepon Unix and Windows. Closes #137.Some targets like
wasm32-unknown-unknowndon't support blocking, so you won't be able to use flume on those platforms without this new feature. Even if you enable-Ctarget-feature=+atomics,+bulk-memory,+mutable-globalson thewasm32-unknown-unknowntarget, flume still doesn't work on the main thread of a web browser, it only works in web workers. See #137 for more details about this, but essentially the problem is that thewait_lockfunction in flume has two different implementations and both of them are blocking, including the current spinlock-based one.