Update dev dependencies #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
force-pushed
the
update-dev-deps
branch
from
2ad4beb
to
d6b92bf
Compare
jayvdb
force-pushed
the
update-dev-deps
branch
from
d6b92bf
to
1f2040d
Compare
jayvdb
commented
Sep 17, 2024
| @@ -33,9 +33,9 @@ nanorand = { version = "0.7", features = ["getrandom"], optional = true } | |||
| #flume-test = { path = "../flume-test" } | |||
| crossbeam-channel = "0.5.5" | |||
| crossbeam-utils = "0.8.10" | |||
| criterion = "0.3.4" | |||
| criterion = { version = "0.5.1", default-features = false } | |||
There was a problem hiding this comment.
default features needs to be disabled to avoid
Compiling criterion v0.5.1
error: Rayon cannot be used when targeting wasi32. Try disabling default features.
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/criterion-0.5.1/src/lib.rs:31:1
|
31 | compile_error!("Rayon cannot be used when targeting wasi32. Try disabling default features.");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: could not compile `criterion` (lib) due to 1 previous error
There was a problem hiding this comment.
@zesterer , the workflows should be green now.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.