Fix nondeterministic bug in RecvSelection::deinit #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Arc::ptr_eq on trait object pointers can fail unpredictably because of rust-lang/rust#46139. This can prevent a Hook from being removed when its RecvSelection is de-inited, which makes it incorrectly push Tokens to a queue owned by a Selector that no longer exists. This may be the cause of zesterer#44.
|
Good catch! I'd forgotten that trait object vtables can be different across compilation units. I'll release a new version. |
|
I've released |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Arc::ptr_eq on trait object pointers can fail unpredictably because of rust-lang/rust#46139.
This can prevent a Hook from being removed when its RecvSelection is de-inited, which makes it incorrectly push Tokens to a queue owned by a Selector that no longer exists.
I found this bug using a test case provided by @scaphe in the Rust Users forum here: https://users.rust-lang.org/t/flume-question-possible-bug/55259
This may also be the cause of #44.