Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Side nav favicon updates #2013

Merged
merged 4 commits into from
Apr 26, 2023
Merged

FIX: Side nav favicon updates #2013

merged 4 commits into from
Apr 26, 2023

Conversation

finnar-bin
Copy link
Contributor

@finnar-bin finnar-bin commented Apr 24, 2023 •
edited
Loading

  • Added default favicon with instance initial when no favicon is uploaded
  • Added function to update favicon when user hovers and clicks on the favicon at the dropdown menu
  • Added a default white background for the favicon

2023-04-24 08 09 36 8-f48cf3a682-7fthvk manager dev zesty io d8cb0a1ad840
Screenshot from 2023-04-24 11-05-45
2023-04-24 11 05 10 8-f48cf3a682-7fthvk manager dev zesty io f8f38f6e0ae8

Closes #1997
Closes #2001
Closes #2006

@finnar-bin finnar-bin self-assigned this Apr 24, 2023
@shrunyan shrunyan merged commit 07fdce7 into master Apr 26, 2023
@shrunyan shrunyan deleted the fix/1997-side-nav-favicon branch April 26, 2023 18:19
This was referenced Mar 27, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalin920 agalin920 agalin920 approved these changes

Assignees

@finnar-bin finnar-bin

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@finnar-bin @agalin920 @shrunyan