Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: App sidebar redesigns #2225

Merged
merged 201 commits into from
Aug 24, 2023
Merged

Feat: App sidebar redesigns #2225

merged 201 commits into from
Aug 24, 2023

Conversation

finnar-bin
Copy link
Contributor

Updated app sidebars for the following:

  • Schema
  • Media
  • Reports
  • Apps

Schema

Screenshot_20230815_142144

Media

Screenshot_20230815_142155

Reports

Screenshot_20230815_142129

Apps

Screenshot_20230815_142100

@finnar-bin finnar-bin removed the ready PR is complete and ready for deployment label Aug 21, 2023
@shrunyan
Copy link
Contributor

image

app crash when clearing local storage

Copy link

@zcolah zcolah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem
Currently it is not evident to a user what order they have sorted everything by.

CleanShot 2023-08-24 at 04 38 57@2x

Solution
Please have the selected menu option be in the selected state so that it is clear to the user what the current sorting is.

@zcolah zcolah added vqa VQA is complete and approved hand-off-ready labels Aug 23, 2023
@finnar-bin finnar-bin added the ready PR is complete and ready for deployment label Aug 24, 2023
@shrunyan shrunyan merged commit 4491612 into master Aug 24, 2023
1 check failed
@shrunyan shrunyan deleted the feature/reports-sidebar-redesign branch August 24, 2023 00:28
@sentry-io
Copy link

sentry-io bot commented Aug 27, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SyntaxError: JSON Parse error: Unexpected EOF <object>.ContentProps.onDrop(src/shell/componen... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hand-off-ready ready PR is complete and ready for deployment vqa VQA is complete and approved
Projects
None yet
4 participants