Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Global Search Phase 2 #2023

Merged
merged 5 commits into from
May 4, 2023
Merged

Feat: Global Search Phase 2 #2023

merged 5 commits into from
May 4, 2023

Conversation

finnar-bin
Copy link
Contributor

@finnar-bin finnar-bin commented May 2, 2023

Added advanced global search filters

image
image
image

* task: added sortby filter

* task: rename sortby filter

* task: add user filter

* task: close menu on select

* task: add select highlight

* task: add date range to date filters

* task: set params for daterange filter

* task: set active filter text

* task: remove date filter

* task: pass active daterange value to daterange picker

* fix: fixed ts error
* task: added sortby filter

* task: rename sortby filter

* task: add user filter

* task: close menu on select

* task: add select highlight

* task: add date range to date filters

* task: set params for daterange filter

* task: set active filter text

* task: remove date filter

* task: pass active daterange value to daterange picker

* fix: fixed ts error

* - do not open a new tab when filters are added
- unpin specific tab when search queries are present
- show search keyword on tab name for the search page

* task: sort by function

* task: user filter

* task: background color update

* task: spacing fix

* task: date filter func

* task: updated result count

* task: fixed alignment

* task: added no results for filter
* task: added advanced search button

* task: added filter button

* chore: removed comment

* task: added advanced search modal

* task: fixed console errors

* task: fixed console error

* task: add form fields

* task: added tooltips
* task: added advanced search button

* task: added filter button

* chore: removed comment

* task: added advanced search modal

* task: fixed console errors

* task: fixed console error

* task: add form fields

* task: added tooltips

* task: created hook for advance search data

* task: moved search data to content search comp

* task: added clear all function

* task: wire user filter

* task: import types

* task: moved everything back into the advance search modal

* task: moved date config to a separate file & added daterange modal

* task: added date handling for single date picker

* task: daterange handler

* task: wired advance search page

* task: wired advance search function

* task: spacing and color update

* fix: fixed search button not enabling

* task: added cypress test scenarios

* task: search page cypress tests

* task: advance search modal cypress tests

* task: added data-cy

* task: updated cy get chaining

* fix: height fix for the counter

* task: added tooltips and changed date filter to modified at

* task: vqa updates

* task: adjusted border radius
@finnar-bin finnar-bin self-assigned this May 2, 2023
@shrunyan shrunyan removed their request for review May 3, 2023 23:46
src/shell/store/ui.ts Show resolved Hide resolved
@agalin920 agalin920 self-requested a review May 4, 2023 06:59
@zcolah
Copy link

zcolah commented May 4, 2023

RULES

  1. If I have made a query, and I have pinned the tab, and I apply a few filters, do not open a new tab. Apply to current tab itself.
  2. If I have made a query and I have pinned the tab, and I write a new query in that tab, open a new tab.

We will create tickets for other pages like media after.

@shrunyan shrunyan merged commit 2e905c2 into master May 4, 2023
@shrunyan shrunyan deleted the feat/global-search-phase2 branch May 4, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Search: UX Overhaul and added ability to search schema, media, and code
4 participants