Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Dataset items header menu updates #2297

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix: Dataset items header menu updates #2297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29d8ddc
task: hide preview menu for dataset items
finnar-bin Oct 18, 2023
09d34c3
task: hide view site generators for dataset items
finnar-bin Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions src/apps/content-editor/src/app/views/ItemEdit/components/ItemEditHeader/MoreMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import { ApiType } from "../../../../../../../schema/src/app/components/ModelApi
import { useGetDomainsQuery } from "../../../../../../../../shell/services/accounts";
import { useFilePath } from "../../../../../../../../shell/hooks/useFilePath";
import { DeleteItemDialog } from "./DeleteItemDialog";
import { useGetContentModelsQuery } from "../../../../../../../../shell/services/instance";

export const MoreMenu = () => {
const { modelZUID, itemZUID } = useParams<{
Expand All @@ -51,6 +52,9 @@ export const MoreMenu = () => {
const instance = useSelector((state: AppState) => state.instance);
const { data: domains } = useGetDomainsQuery();
const codePath = useFilePath(modelZUID);
const { data: contentModels } = useGetContentModelsQuery();
const type =
contentModels?.find((model) => model.ZUID === modelZUID)?.type ?? "";

const handleCopyClick = (data: string) => {
navigator?.clipboard
Expand Down Expand Up @@ -132,18 +136,20 @@ export const MoreMenu = () => {
View Quick Access API
<KeyboardArrowRightRounded color="action" sx={{ ml: "auto" }} />
</MenuItem>
<MenuItem
onClick={(event) => {
setShowApiEndpoints(event.currentTarget);
setApiEndpointType("site-generators");
}}
>
<ListItemIcon>
<DataObjectRounded />
</ListItemIcon>
View Site Generators API
<KeyboardArrowRightRounded color="action" sx={{ ml: "auto" }} />
</MenuItem>
{type !== "dataset" && (
<MenuItem
onClick={(event) => {
setShowApiEndpoints(event.currentTarget);
setApiEndpointType("site-generators");
}}
>
<ListItemIcon>
<DataObjectRounded />
</ListItemIcon>
View Site Generators API
<KeyboardArrowRightRounded color="action" sx={{ ml: "auto" }} />
</MenuItem>
)}
<MenuItem
onClick={() => {
history.push(`/schema/${modelZUID}`);
Expand Down
7 changes: 6 additions & 1 deletion src/apps/content-editor/src/app/views/ItemEdit/components/ItemEditHeader/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import { useState } from "react";
import { PreviewMenu } from "./PreviewMenu";
import { styled } from "@mui/system";
import { useGetInstalledAppsQuery } from "../../../../../../../../shell/services/accounts";
import { useGetContentModelsQuery } from "../../../../../../../../shell/services/instance";

const tabs = [
{
Expand Down Expand Up @@ -88,12 +89,16 @@ export const ItemEditHeader = ({ saving, onSave }: HeaderProps) => {
const history = useHistory();
const [showDuplicateItemDialog, setShowDuplicateItemDialog] = useState(false);
const { data: installedApps } = useGetInstalledAppsQuery();
const { data: contentModels } = useGetContentModelsQuery();

const item = useSelector(
(state: AppState) =>
state.content[itemZUID] as ContentItemWithDirtyAndPublishing
);

const type =
contentModels?.find((model) => model.ZUID === modelZUID)?.type ?? "";

const layoutsAppInstalled = installedApps?.find(
(app) => app.appZUID === "80-d8abaff6ef-wxs830"
);
Expand Down Expand Up @@ -160,7 +165,7 @@ export const ItemEditHeader = ({ saving, onSave }: HeaderProps) => {
>
<ContentCopyRounded fontSize="small" />
</IconButton>
<PreviewMenu />
{type !== "dataset" && <PreviewMenu />}
<ItemEditHeaderActions saving={saving} onSave={onSave} />
</Box>
</Box>
Expand Down