Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta Release #2879

Closed
wants to merge 13 commits into from
Closed

Beta Release #2879

wants to merge 13 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

Created by Github action

github-actions bot and others added 3 commits July 24, 2024 13:35
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
@zcolah
Copy link

zcolah commented Jul 25, 2024

Currency Field Revamp

@finnar-bin

@zcolah
Copy link

zcolah commented Jul 25, 2024

Schema - Media Field Rules

@agalin920

  • Note: you may move default value to the top like the other fields
    image

  • Add ability to delete with backspace
    image

agalin920 and others added 4 commits July 30, 2024 12:32
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
@zcolah
Copy link

zcolah commented Jul 31, 2024

Schema Rules - Media Field

@agalin920

@agalin920
Copy link
Contributor

agalin920 commented Jul 31, 2024

Schema Rules - Media Field

@agalin920

@zcolah Bug is intentional. Current experience is autofill is only enabled on rule enable since there is currently no way to know whether a message was modified when you go back and edit the rule. Maybe we should have a button or checkbox to enable it again.

I do not believe the added overhead of a field specific flag is worth saving in local storage or even in the field settings itself.

@zcolah
Copy link

zcolah commented Jul 31, 2024 via email

@agalin920
Copy link
Contributor

agalin920 commented Jul 31, 2024

@zcolah np just some extra info state does not persist after the component unmounts (goes out of view) or if the page refreshes. In order to persist state we need to leverage local storage or database. Hence my point of I personally don't believe it's worth persisting.

finnar-bin and others added 2 commits August 1, 2024 09:24
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
@zcolah
Copy link

zcolah commented Aug 1, 2024

Media File Replacement

@finnar-bin

@finnar-bin
Copy link
Contributor

@zcolah that image seems to come from a template and not from the zesty media app. The file replacement doesn't support it since that file technically isn't present in the media app. As discussed, I'll be hiding the replace file option for url files like that one.

finnar-bin and others added 2 commits August 2, 2024 08:57
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
@zcolah
Copy link

zcolah commented Aug 2, 2024

Multi Page Table - Sorting

@finnar-bin

@zcolah
Copy link

zcolah commented Aug 2, 2024

Projects for Me to Check

It's become very difficult to track all the issues the Beta Release is resolving. Hence I am making a list below that will make it easy for me to track if I have checked everything pre-release.

Media

  • File replacement

Schema

  • Schema rules limit file type for media field
  • Currency field revamp

Content

  • Currency field revamp
  • Do not show edit template for datasets
  • Do not show the model as a breadcrumb item when in multipag…
  • Fix/table sort by display date field by accounting for empty date val…
  • Reference createdAt timestamp outside of history object
  • Do not store pinned columns to local storage
  • Multipage table advanced sorting
  • Filter button icon update & show api endpoints on hover
  • Only show publish actions when dropdown selection has chang…
  • Remove replace file option for non-zesty media files
  • Show image placeholder in publish modal dialog

Roles

  • Enhancment/Grant app permissions to new system roles
  • Hide publish based on permissions on code app

@finnar-bin
Copy link
Contributor

finnar-bin commented Aug 5, 2024

Multi Page Table - Sorting

@finnar-bin

The table is actually sorted by "last saved" descending by default all the time when no other sorting is applied. If you check the sorting pill, it always goes back to "Last Saved" when you click the table header for the 3rd time to remove that column's sorting.

@zcolah
Copy link

zcolah commented Aug 5, 2024

Multi Page Table - Sorting

@finnar-bin

The table is actually sorted by "last saved" descending by default all the time when no other sorting is applied. If you check the sorting pill, it always goes back to "Last Saved" when you click the table header for the 3rd time to remove that column's sorting.

@finnar-bin
Here is reply: https://www.loom.com/share/0e6545343a6842dda8e123c962d8f75b?from_recorder=1&focus_title=1

@finnar-bin
Copy link
Contributor

finnar-bin commented Aug 5, 2024

@zcolah as discussed on the call, we'll be highlighting the last saved sorting every time the other header sorting are removed

finnar-bin and others added 2 commits August 6, 2024 10:40
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
@agalin920 agalin920 closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants