cosmos v50.x upgrade [DRAFT] #179

skosito · 2025-01-05T17:01:12Z

No description provided.

fix dependencies fix build upgrade protogen image Co-authored-by: mmsqe <mavis@crypto.com> wait for block properly fix py-lint fix test fix py-lint

coderabbitai · 2025-01-05T17:01:20Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Finishing Touches

📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tests/integration_tests/network.py

@@ -9,7 +9,7 @@
 from web3.middleware import geth_poa_middleware

 from .cosmoscli import CosmosCLI
-from .utils import wait_for_port
+from .utils import supervisorctl, w3_wait_for_block, wait_for_port


tests/integration_tests/test_fee_history.py

@@ -3,14 +3,23 @@
 import pytest
 from web3 import Web3

-from .network import setup_ethermint
-from .utils import ADDRS, send_transaction
+from .network import setup_custom_ethermint


tests/integration_tests/test_tracers.py

+        }
+        sended_hash_set = send_txs(w3, txs)
+        for txhash in sended_hash_set:
+            res = w3.eth.wait_for_transaction_receipt(txhash, timeout=10)


tests/integration_tests/test_upgrade.py

-#     wait_for_port,
-# )
+import pytest
+from pystarport import ports


tests/integration_tests/test_upgrade.py

-# )
+import pytest
+from pystarport import ports
+from pystarport.cluster import SUPERVISOR_CONFIG_FILE


tests/integration_tests/test_upgrade.py

+from pystarport import ports
+from pystarport.cluster import SUPERVISOR_CONFIG_FILE
+
+from .network import Ethermint, setup_custom_ethermint


tests/integration_tests/test_upgrade.py

+from .utils import (
+    ADDRS,
+    CONTRACTS,
+    approve_proposal,
+    deploy_contract,
+    send_transaction,
+    wait_for_block,
+    wait_for_port,
+)


tests/integration_tests/test_websockets.py

+                await t
+            except asyncio.CancelledError:
+                print("cancel")
+                pass


app/ante/fee_checker.go

server/start.go

x/evm/keeper/msg_server.go

x/evm/keeper/state_transition.go

x/feemarket/keeper/abci.go

app/app.go

+	for _, m := range app.ModuleManager.Modules {
+		if moduleWithName, ok := m.(module.HasName); ok {
+			moduleName := moduleWithName.Name()
+			if appModule, ok := moduleWithName.(appmodule.AppModule); ok {
+				modules[moduleName] = appModule
+			}
+		}
+	}


cmd/ethermintd/root.go

x/evm/module.go

-func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) {
-	am.keeper.BeginBlock(ctx, req)
+func (am AppModule) BeginBlock(ctx context.Context) error {
+	return am.keeper.BeginBlock(sdk.UnwrapSDKContext(ctx))


x/evm/types/chain_config.go

x/evm/types/msg.go

x/feemarket/keeper/eip1559.go

-	if consParams != nil && consParams.Block.MaxGas > -1 {
-		gasLimit = big.NewInt(consParams.Block.MaxGas)
+	if consParams.Block == nil || consParams.Block.MaxGas <= -1 {
+		panic(fmt.Sprintf("get invalid consensus params: %s", consParams))


x/feemarket/keeper/params.go

+	store := k.storeService.OpenKVStore(ctx)
+	bz, err := store.Get(types.ParamsKey)
+	if err != nil {
+		panic(err)


x/feemarket/module.go

-func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) {
-	am.keeper.BeginBlock(ctx, req)
+func (am AppModule) BeginBlock(ctx context.Context) error {
+	return am.keeper.BeginBlock(sdk.UnwrapSDKContext(ctx))


x/feemarket/module.go

-	am.keeper.EndBlock(ctx, req)
-	return []abci.ValidatorUpdate{}
+func (am AppModule) EndBlock(ctx context.Context) error {
+	return am.keeper.EndBlock(sdk.UnwrapSDKContext(ctx))


yihuang and others added 2 commits January 5, 2025 17:59

Problem: sdk 0.50 is not used

99eeed5

fix dependencies fix build upgrade protogen image Co-authored-by: mmsqe <mavis@crypto.com> wait for block properly fix py-lint fix test fix py-lint

fix imports

4f2e139

github-actions bot added C:Encoding C:Proto C:Types Type: Build C:CLI Type: Tests Type: Docs labels Jan 5, 2025

github-advanced-security bot found potential problems Jan 5, 2025

View reviewed changes

skosito added 6 commits January 5, 2025 19:09

go mod fixes

5f4e528

revert statedb changes

a6a6400

proto fixes

21c3df7

clesnup migrations

ac1b2bb

fixes

8436859

tmp comment code

42c9a4f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cosmos v50.x upgrade [DRAFT] #179

cosmos v50.x upgrade [DRAFT] #179

skosito commented Jan 5, 2025

coderabbitai bot commented Jan 5, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

cosmos v50.x upgrade [DRAFT] #179

Are you sure you want to change the base?

cosmos v50.x upgrade [DRAFT] #179

Conversation

skosito commented Jan 5, 2025

coderabbitai bot commented Jan 5, 2025 • edited Loading

Review skipped

Finishing Touches

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot commented Jan 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)