Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update onCrossChainCall with zContext #43

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Aug 10, 2023

@fadeev fadeev linked an issue Aug 10, 2023 that may be closed by this pull request
@socket-security
Copy link

socket-security bot commented Aug 10, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@zetachain/toolkit 1.0.5-athens3 None +0 1.61 MB lucasjanon
@zetachain/protocol-contracts 2.0.1 None +0 2.7 MB lucasjanon

@andresaiello
Copy link
Collaborator

you can include in the pr what we talked about adding

 if (msg.sender != systemContract) {
            revert InvalidSender();
        }
        ```

@fadeev
Copy link
Member Author

fadeev commented Aug 17, 2023

Added the check that the sender is system contract. I've renamed it to error SenderNotSystemContract() to make more descriptive.

@fadeev fadeev merged commit 28a3c6e into main Aug 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update onCrossChainCall with zContext
2 participants