Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate Smart Contract V2 depositAndCall for ETH and ERC20 #2639

Merged
merged 12 commits into from
Aug 8, 2024

fix unit tests

b82c498
Select commit
Loading
Failed to load commit list.
Merged

feat: integrate Smart Contract V2 depositAndCall for ETH and ERC20 #2639

fix unit tests
b82c498
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 8, 2024 in 0s

68.72% (-1.44%) compared to 0a596a9

View this Pull Request on Codecov

68.72% (-1.44%) compared to 0a596a9

Details

Codecov Report

Attention: Patch coverage is 35.32110% with 141 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (0a596a9) to head (b82c498).

Files Patch % Lines
pkg/contracts/testdappv2/TestDAppV2.go 0.00% 122 Missing ⚠️
x/fungible/keeper/v2_evm.go 76.92% 3 Missing and 3 partials ⚠️
x/crosschain/keeper/evm_deposit.go 72.22% 5 Missing ⚠️
zetaclient/chains/evm/observer/v2_inbound.go 0.00% 5 Missing ⚠️
x/observer/types/chain_params.go 89.65% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           feat/contract-v2-2    #2639      +/-   ##
======================================================
- Coverage               70.15%   68.72%   -1.44%     
======================================================
  Files                     337      341       +4     
  Lines                   18468    18906     +438     
======================================================
+ Hits                    12957    12993      +36     
- Misses                   4930     5329     +399     
- Partials                  581      584       +3     
Files Coverage Δ
pkg/contracts/erc1967proxy/ERC1967Proxy.go 0.00% <ø> (ø)
pkg/crypto/address.go 100.00% <100.00%> (ø)
x/crosschain/keeper/evm_hooks.go 84.65% <ø> (ø)
x/fungible/keeper/deposits.go 95.23% <100.00%> (ø)
x/fungible/keeper/evm.go 88.30% <100.00%> (+0.07%) ⬆️
x/fungible/keeper/gas_coin_and_pool.go 91.66% <ø> (ø)
...ngible/keeper/msg_server_update_system_contract.go 93.06% <ø> (ø)
x/fungible/keeper/system_contract.go 90.37% <ø> (ø)
x/fungible/keeper/v2_deposits.go 100.00% <100.00%> (ø)
x/observer/types/chain_params.go 92.88% <89.65%> (ø)
... and 4 more