Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove v2 migration test from scheduled CI and release workflow #3013

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Oct 17, 2024

Description

The test is not functional when running from develop as it uses v2 contracts pre-deployed by default
 
Just keep it in manual workflow for now for exceptional case (we have to make a new hotfix on v20)

Will be completely removed once v2 migration completed

Summary by CodeRabbit

  • Chores
    • Updated test execution logic to streamline conditions for running specific tests based on GitHub event types.
    • Removed certain outputs for push and schedule events, focusing on workflow_dispatch events for V2_MIGRATION_TESTS.

@lumtis lumtis requested a review from a team as a code owner October 17, 2024 08:03
Copy link
Contributor

coderabbitai bot commented Oct 17, 2024

📝 Walkthrough

Walkthrough

The changes in the .github/workflows/e2e.yml file focus on modifying the logic for determining which tests to execute based on various GitHub event contexts. The setting of the V2_MIGRATION_TESTS output has been refined to only apply to workflow_dispatch events, while it is omitted for push events targeting release/* branches and schedule events. The overall structure and job dependencies of the workflow remain unchanged, ensuring that the matrix configuration continues to utilize outputs from the matrix-conditionals job.

Changes

File Change Summary
.github/workflows/e2e.yml Updated matrix-conditionals job logic to set V2_MIGRATION_TESTS only for workflow_dispatch events; removed settings for push and schedule events.

Possibly related PRs

Suggested labels

ci, no-changelog

Suggested reviewers

  • skosito
  • gartnera
  • fbac
  • kingpinXD
  • ws4charlie

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 250b90e and 53f526d.

📒 Files selected for processing (1)
  • .github/workflows/e2e.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/e2e.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Oct 17, 2024
@lumtis lumtis added the no-changelog Skip changelog CI check label Oct 17, 2024
@lumtis lumtis added this pull request to the merge queue Oct 17, 2024
Merged via the queue into develop with commit 923b936 Oct 17, 2024
37 of 38 checks passed
@lumtis lumtis deleted the ci/remove-nightly-v2-migration branch October 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants