Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd): set the correct default HD path for key recovery #913

Merged
merged 6 commits into from
Aug 11, 2023
Merged

fix(cmd): set the correct default HD path for key recovery #913

merged 6 commits into from
Aug 11, 2023

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Aug 7, 2023 •
edited
Loading

Description

  • Implement a utility method to replace default flags of command
  • Replace the default hd-path to Ethereum for keys add

Closes: #856

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis self-assigned this Aug 7, 2023
@lumtis lumtis marked this pull request as ready for review August 7, 2023 08:55
@lumtis lumtis merged commit 9e88eab into develop Aug 11, 2023
16 checks passed
@lumtis lumtis deleted the fix/hd-path branch August 11, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingpinXD kingpinXD kingpinXD approved these changes

@brewmaster012 brewmaster012 brewmaster012 approved these changes

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

Assignees

@lumtis lumtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zetacored keys should default to the right HD path value
3 participants
@lumtis @kingpinXD @brewmaster012