refactor(app.go): remove capability module

[lumtis]

Description

Remove capability module since not used.
Didn't identify other unused module. params should be removed too but it should be part of a bigger refactoring since modules must manage their own store for their params

Closes: #726

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

Checklist:

• I have added unit tests that prove my fix feature works

[fadeev]

We can also probably remove this note:

node/app/app.go

Line 520 in 387a701

// NOTE: Capability module must occur first so that it can initialize any capabilities

And remove it from the genesis:

node/contrib/localnet/zetacored/zetacored_zetacore0/config/genesis.json

Lines 152 to 155 in 387a701

	"capability": {
	"index": "1",
	"owners": []
	},

node/contrib/localnet/zetacored/zetacored_zetacore1/config/genesis.json

Lines 152 to 155 in 387a701

	"capability": {
	"index": "1",
	"owners": []
	},

[lumtis]

We can also probably remove this note:

Can be useful if we add back the module, WDYT?

[brewmaster012]

This is a big in smoketest, causing intermittent failures. Fixed in my PR #912

…

________________________________ From: Lucas Bertrand ***@***.***> Sent: Monday, August 7, 2023 7:57:01 AM To: zeta-chain/node ***@***.***> Cc: brewmaster012 ***@***.***>; Review requested ***@***.***> Subject: Re: [zeta-chain/node] refactor(`app.go`): remove `capability` module (PR #914) Seems to be some issues with the smoke test panic: -26: non-mandatory-script-verify-flag (Witness program hash mismatch) Didn't have this error locally though — Reply to this email directly, view it on GitHub<#914 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVEUZQ4MWSCD56RTQUTUXR3XUDQZ3ANCNFSM6AAAAAA3GWNOBM>. You are receiving this because your review was requested.Message ID: ***@***.***>