Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zetaclient): use outTxParams for the used amount in evm WithdrawTx #996

Closed
wants to merge 4 commits into from

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Aug 18, 2023

Description

This fix is part of #980 but doesn't fix it completely. We need to add the actually payment of gas for ZETA withdraw. I'm currently investigating another bug in #991 where calling EVM in EVM post tx hook makes the node crashing.
I open this PR to get approval on this first fix.

Update in Zetaclient send.InboundTxParams.Amount.BigInt() to send.GetCurrentOutTxParam().Amount.BigInt() when signing txs to get the amount updated from the gas payment.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis self-assigned this Aug 18, 2023
@lumtis lumtis marked this pull request as ready for review August 18, 2023 09:09
@lumtis lumtis changed the title fix(zetaclient): use outTxParams for the amount using in evm WithdrawTx fix(zetaclient): use outTxParams for the used amount in evm WithdrawTx Aug 18, 2023
@lumtis
Copy link
Member Author

lumtis commented Aug 22, 2023

Closing since #991 now contains the full fix

@lumtis lumtis closed this Aug 22, 2023
@lumtis lumtis deleted the fix/client-cctx-amount branch October 27, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant