Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update protocol contracts npm version to 0.8.0 #63

Merged
merged 2 commits into from
Jul 27, 2023
Merged

build: update protocol contracts npm version to 0.8.0 #63

merged 2 commits into from
Jul 27, 2023

Conversation

andresaiello
Copy link
Collaborator

Summary

  • Update npm with latest changes

@andresaiello andresaiello marked this pull request as ready for review July 27, 2023 15:01
lucas-janon
lucas-janon previously approved these changes Jul 27, 2023
View reviewed changes
Copy link

@lucas-janon lucas-janon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@andresaiello andresaiello changed the title update protocol contracts npm version to 0.8.0 build: update protocol contracts npm version to 0.8.0 Jul 27, 2023
@andresaiello andresaiello merged commit 14a502e into main Jul 27, 2023
6 of 7 checks passed
@andresaiello andresaiello deleted the andy/pd-4065-update-protocol-contracts-npm-version-to-080 branch July 27, 2023 15:23
@fadeev
Copy link
Member

fadeev commented Jul 28, 2023

Thanks to this workflow the version is set automatically on publish:

protocol-contracts/.github/workflows/publish-npm.yaml

Line 37 in 14a502e

run: yarn publish --new-version ${GITHUB_REF#refs/tags/v} --tag ${{ steps.determine-npm-tag.outputs.NPM_TAG }} --no-git-tag-version

We might as well put a placeholder in package.json to make it more clear:

https://github.com/zeta-chain/toolkit/blob/5aa7738a5532524d13f20a1e7c53436ebb70132e/package.json#L3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-janon lucas-janon lucas-janon approved these changes

@fadeev fadeev Awaiting requested review from fadeev fadeev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresaiello @fadeev @lucas-janon