Enable stacked rendering for horizontal bar charts #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derickr is this close enough to what you wanted to see that we could get this merged? |
|
Sorry - haven't had the time to look yet. I think it all looks mostly okay, but shouldn't it update some documentation too? For example, https://github.com/zetacomponents/Graph/pull/19/files#diff-d1d371f35ebe23b27f89983268e0f83dR373 should have an update at https://github.com/madscientist159/Graph/blob/horiz-stacked-render/src/options/line_chart.php#L56 too? I am sure the others need some more docs too. And there are some issues with coding standards that I will have to fix before merging. Hope to get to this during this week... but too many side projects (and life)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #18