gltfpack: Remove point normal streams when they are constant #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a separate implementation, we now have isConstant function that can check the entire vertex stream; this will be useful in the future.
A fair amount of point cloud exports to glTF seem to have a redundant normal stream (filled with the same value). This is relatively common (about one in 6-7 files from Sketchfab has this issue), and it results in incorrect rendering for renderers that respect normals *and* extra data (4 out of 16 bytes in point clouds with normals & colors). While it may sometimes be incorrect to remove this data, for now let's err on the side of aggressive optimization and detect & remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fair amount of point cloud exports to glTF seem to have a redundant
normal stream (filled with the same value). This is relatively common
(about one in 6-7 files from Sketchfab has this issue), and it results
in incorrect rendering for renderers that respect normals and extra
data (4 out of 16 bytes in point clouds with normals & colors).
While it may sometimes be incorrect to remove this data, for now let's
err on the side of aggressive optimization and detect & remove it.