Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ditch travis in favor of gha workflow #108

Merged
merged 2 commits into from
Oct 1, 2021
Merged

ditch travis in favor of gha workflow #108

merged 2 commits into from
Oct 1, 2021

Conversation

falkenhawk
Copy link
Member

@falkenhawk falkenhawk commented Oct 1, 2021

It's time to ditch travis.
Even though it kinda works at the moment after they topped up the oss credits, but it again started failing on php 5.3.
But, thanks to @glensc, tests are ported to run on Github Actions. 🎉

Current status - travis: (php 8.0)

OK, but incomplete or skipped tests!

Tests: 15522, Assertions: 61406, Incomplete: 22, Skipped: 607.

GHA: (php 8.0)

OK, but incomplete or skipped tests!
Tests: 15572, Assertions: 61707, Incomplete: 21, Skipped: 585.

There are even less tests skipped on GHA compared to travis. 🎉

Note: postgres and sqlite tests are not performed at the moment, but they may be added at a later date. Even without them, the total number of run tests are higher than on travis.

@falkenhawk
Copy link
Member Author

haha, I tried my luck with re-enabling tests which have been always skipped because they "randomly fail on Travis CI"

It looks like failures are not random on GHA, as they happened on every run in https://github.com/zf1s/zf1/runs/3765273246 😅

There must be something off going on inside Zend_Cache... but I will make the tests skipped again for now and hopefully tackle that in a separate PR (somewhen...)

@falkenhawk
Copy link
Member Author

It may be not that bad after all, as failures seems to be deterministic and there is only one cache backend failing ("Memcached"):

1) Zend_Cache_MemcachedBackendTest::testCleanModeAll
Failed asserting that false is true.

/home/runner/work/zf1/zf1/tests/Zend/Cache/CommonBackendTest.php:234

for some reason memcache->flush() returns false.
@falkenhawk falkenhawk changed the title ditch travis in favor of gha workflow Ditch Travis Oct 1, 2021
@falkenhawk falkenhawk changed the title Ditch Travis ditch travis Oct 1, 2021
@falkenhawk falkenhawk changed the title ditch travis ditch travis in favor of gha workflow Oct 1, 2021
@falkenhawk falkenhawk merged commit bd620e9 into master Oct 1, 2021
@falkenhawk falkenhawk deleted the ditch-travis branch October 1, 2021 09:57
@falkenhawk
Copy link
Member Author

postgres enabled in #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants