[zend-exception] allow Throwable in $previous #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor overload must stay because zf1 relies on code being casted to int there in many places (e.g. exceptions coming from PDO, which may have `long` or `string` codes...) Relax the type declaration to allow passing any type (as typing `Throwable` would not work in php 5.x) and just let the base `Exception` class check and throw on invalid type.
marcing
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the type declaration to allow passing any type (as typing
Throwablewould not work in php 5.x) and just let the baseExceptionclass check and throw on invalid type.Note: The constructor overload must stay because zf1 relies on code being casted to int there in many places (e.g. exceptions coming from PDO, which may have
longorstringcodes...)