Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Enable php 8.1/8.2 experimental #129

Merged
merged 2 commits into from
Oct 11, 2022
Merged

CI: Enable php 8.1/8.2 experimental #129

merged 2 commits into from
Oct 11, 2022

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Oct 3, 2022 •
edited
Loading

Just to have 8.1/8.2 running in CI

@glensc
Copy link
Contributor Author

glensc commented Oct 3, 2022

The first task is to make phpunit compatible:

Run vendor/bin/phpunit --verbose || $FAILURE_ACTION
PHP Fatal error:  Cannot acquire reference to $GLOBALS in /home/runner/work/zf1/zf1/vendor/zf1s/phpunit/PHPUnit/Util/Configuration.php on line 541

@glensc
Copy link
Contributor Author

glensc commented Oct 3, 2022

It seems to be worked on already:

@fredericgboutin-yapla fredericgboutin-yapla mentioned this pull request Oct 4, 2022
Closed
@falkenhawk
Copy link
Member

zf1s/phpunit#9 has been merged.
@glensc will you switch to https://github.com/zf1s/phpunit/releases/tag/3.7.41 here please? You may also enable 8.2 in gha at the same time, just to have it already running.

@glensc glensc changed the title CI: Enable php 8.1 experimental CI: Enable php 8.1/8.2 experimental Oct 11, 2022
@glensc glensc marked this pull request as ready for review October 11, 2022 13:24
@glensc
Copy link
Contributor Author

glensc commented Oct 11, 2022

CI green (can be merged), but tests don't pass (as expected):

falkenhawk
falkenhawk approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks!

@falkenhawk falkenhawk merged commit f7b964a into zf1s:master Oct 11, 2022
@glensc glensc deleted the php-8.1 branch October 11, 2022 14:39
@falkenhawk falkenhawk mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkenhawk falkenhawk falkenhawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @falkenhawk