Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zend-ldap]: fix failing tests #172

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[zend-ldap]: fix failing tests #172

merged 1 commit into from
Dec 14, 2023

Conversation

falkenhawk
Copy link
Member

@falkenhawk falkenhawk commented Dec 14, 2023 •
edited
Loading

[zend-ldap]: fix failing tests due to changes in bitnami/openldap:2.5

1) Zend_Ldap_BindTest::testRequiresDnWithoutDnBind
Failed asserting that '0x1: Failed to retrieve DN for account: admin@example.com [0x30 (Inappropriate authentication; anonymous bind disallowed): ldap://localhost:1389]' contains "No object found for".

/home/runner/work/zf1/zf1/tests/Zend/Ldap/BindTest.php:184

restore expected message to the previous version, as the error message contains Failed to retrieve DN again 🙈
https://github.com/zf1s/zf1/pull/159/files#diff-10a1b3c35fa477d1ad544c164800886583a4162bf83154247e986d59da216ff5L184

partikus
partikus approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@partikus partikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍
I guess it was OpenLDAP regression. Would be great to find a reference/link to it.

@falkenhawk falkenhawk merged commit 7308a7b into master Dec 14, 2023
12 checks passed
@falkenhawk falkenhawk mentioned this pull request Dec 14, 2023
Merged
@falkenhawk falkenhawk deleted the fix/ldap-tests branch January 3, 2024 11:49
@falkenhawk falkenhawk mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@partikus partikus partikus approved these changes

@marcing marcing Awaiting requested review from marcing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falkenhawk @partikus