Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move composer.json validate of sub-packages to GitHub Actions #40

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Dec 20, 2020

Example failure job output (2 packages):

[...]
Error: "packages/zend-acl/composer.json" does not contain valid JSON
Parse error on line 8:
...: ">=5.3.3"        "zf1s/zend-exception...
---------------------^
Expected one of: 'EOF', '}', ':', ',', ']'
                                                                 
  [Seld\JsonLint\ParsingException]                               
  "packages/zend-acl/composer.json" does not contain valid JSON  
  Parse error on line 8:                                         
  ...: ">=5.3.3"        "zf1s/zend-exception...                  
  ---------------------^                                         
  Expected one of: 'EOF', '}', ':', ',', ']'                     
                                                                 

packages/zend-amf/composer.json is valid
packages/zend-application/composer.json is valid
packages/zend-auth/composer.json is valid
[...]
packages/zend-service-twitter/composer.json is valid
packages/zend-service-windowsazure/composer.json is valid

Error: "packages/zend-service-yahoo/composer.json" does not contain valid JSON
Parse error on line 20:
...l adapters"        "zf1s/zend-validate"
---------------------^
Expected one of: 'EOF', '}', ':', ',', ']'
                                                                           
  [Seld\JsonLint\ParsingException]                                         
  "packages/zend-service-yahoo/composer.json" does not contain valid JSON  
  Parse error on line 20:                                                  
  ...l adapters"        "zf1s/zend-validate"                               
  ---------------------^                                                   
  Expected one of: 'EOF', '}', ':', ',', ']'                               
                                                                           

packages/zend-service/composer.json is valid
packages/zend-session/composer.json is valid
packages/zend-soap/composer.json is valid
[...]
packages/zend-xml/composer.json is valid
packages/zend-xmlrpc/composer.json is valid
Error: Process completed with exit code 1.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@glensc glensc marked this pull request as ready for review December 20, 2020 07:03
@@ -32,6 +32,7 @@ jobs:
with:
php-version: ${{ matrix.php }}
ini-values: display_errors=off, log_errors=on
extensions: :xdebug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding xdebug is not relevant for the scope of this PR, is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

details are in the commit message.

@falkenhawk falkenhawk merged commit a476428 into zf1s:master Dec 21, 2020
@falkenhawk
Copy link
Member

Thank you @glensc for your contribution!

@glensc glensc deleted the composer-validate branch December 21, 2020 12:47
@glensc glensc mentioned this pull request Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants