Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace version_compare on PHP_VERSION with PHP_VERSION_ID check #53

Merged
merged 4 commits into from
Feb 9, 2021
Merged

Replace version_compare on PHP_VERSION with PHP_VERSION_ID check #53

merged 4 commits into from
Feb 9, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Feb 5, 2021 •
edited
Loading

As described in https://bugs.php.net/bug.php?id=80503

PHP 8 doesn't support "gte' operator for version_compare()

I have found this one triggered only in fpm mode which break several things like Zend_Currency
https://github.com/Shardj/zf1-future/blob/c84dedf0e948d9ccaa7a2ac234cc6f6787f05d45/library/Zend/Xml/Security.php#L172

EDIT: The above problem is fixed in #26 already (1.13.4 release)

Refs:

@glensc glensc changed the title Change phpversion() to PHP_VERSION constant Replace version_compare on PHP_VERSION with PHP_VERSION_ID compare Feb 5, 2021
@glensc glensc changed the title Replace version_compare on PHP_VERSION with PHP_VERSION_ID compare Replace version_compare on PHP_VERSION with PHP_VERSION_ID check Feb 5, 2021
This was referenced Feb 5, 2021
Merged
Merged
@glensc glensc force-pushed the version_compare-to-constant branch from a998e9f to ca03780 Compare February 8, 2021 16:57
@glensc
Copy link
Contributor Author

glensc commented Feb 8, 2021 •
edited
Loading

All "rc" version checks were rounded down for simplicity as pointless to support that gradual difference. Should these be rounded up instead?

@glensc glensc marked this pull request as ready for review February 9, 2021 08:12
falkenhawk
falkenhawk approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine to round down that single rc check - no need to go further with checking PHP_EXTRA_VERSION or something

@falkenhawk falkenhawk merged commit b18b99b into zf1s:master Feb 9, 2021
@glensc glensc deleted the version_compare-to-constant branch February 9, 2021 12:23
@glensc glensc mentioned this pull request Aug 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkenhawk falkenhawk falkenhawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @falkenhawk