Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Zend_View_Abstract::__get() phpdoc #87

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 15, 2021

as discussed in phpstan upstream issue phpstan/phpstan#3927 (comment)

to access variables from within a controller via $this->view without a phpstan error, this phpdoc needs to be fixed.

Copy link
Contributor

@glensc glensc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

but note for the future. try to explain the whole context in PR title/body, so the reviewer doesn't have to click links and figure out what did the pull request creator had in mind when they added the link.

ps: cross-linking stuff, is very okay.

Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @staabm !

@falkenhawk falkenhawk merged commit 4e4e70d into zf1s:master Mar 15, 2021
@staabm staabm deleted the patch-2 branch March 15, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants