Some improvements #32
Conversation
prolic
commented
Jun 20, 2016
prolic
commented
- Update to use Zend\Hydrator instead of Zend\Stdlib\Hydrator
- Bug fix of ODM\MongoDB\Types\CurrencyType
- update mapping
- Don't hydrate object if form values wasn't present
* shouldn't use stringtype
Fixation bug currency type
Fixed money hydrator
* at mongo persistence should nor a instance only string
Fixation bug currency type
update mapping
| @@ -20,7 +20,7 @@ class MoneyHydrator implements HydratorInterface | |||
| public function extract($object) | |||
| { | |||
| return [ | |||
| 'amount' => $object->getAmount(), | |||
| 'amount' => $object->getAmount() / 100, | |||
There was a problem hiding this comment.
Why is this? I want the amount in the smallest unit available. Not every currency has decimals.
There was a problem hiding this comment.
Which currency for example? I like to verify your statement.
There was a problem hiding this comment.
Currently I can only think of cryptocurrencies not having decimals.
There was a problem hiding this comment.
Well, cryptocurrencies is fair enough, so I changed this line again.
There was a problem hiding this comment.
Quite a few actually. Here's a list: https://support.stripe.com/questions/which-zero-decimal-currencies-does-stripe-support
Beside this being a BC-break, I really want discourage this change. Working with the smallest unit available is very common practice when performing payments. It's also less error prone (rounding problems).
There was a problem hiding this comment.
According to the provided list, CLP (chilean peso) is a zero-decimal currency, but it's not! There are 100 Centavos for 1 CLP. However GNF (Franc Guinéen) is valid.
|
BC BREAK! Because it uses Zend\Hydrator instead of Zend\Stdlib\Hydrator |
|
Thanks @prolic! |
