This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
replace container-interop/container-interop with psr/container #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.gitignore
Outdated
| @@ -1 +1,2 @@ | |||
| composer.lock | |||
There was a problem hiding this comment.
It should not be ignored, we'd like to run test with locked dependencies (see Travis CI configuration in .travis.yml)
|
I'm quite puzzled about the failed tests, nor I'm able to reproduce these failures myself. Any help would be appreciated. |
- removed fast_finish flag - updated legacy dependencies - removed HHVM build - added PHP 7.1 and PHP 7.2 builds - moved cs-checks and coverage to run on PHP 7.1 with locked deps - removed composer self-update - disabled IRC notifications - set composer output width to 120 chars - coverage upload
|
Great! Once your PR is merged into develop I'll rebase mine and see what happens. |
|
@1ma meanwhile you can try on local to make sure all is good 😄 |
|
Myea, success. |
weierophinney
added a commit
that referenced
this pull request
Nov 27, 2017
replace container-interop/container-interop with psr/container
weierophinney
added a commit
that referenced
this pull request
Nov 27, 2017
weierophinney
added a commit
that referenced
this pull request
Nov 27, 2017
|
Thanks, @1ma |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
container-interop/container-interopis deprecated since Feb. 13th 2017 in favor ofpsr/container(PSR-11 spec). This PR replaces one for the other.My use case
I use Pimple as the DI container to lazy load command handlers. Pimple provides it's own PSR-11 decorator, but it implements PSR-11's interface, not container-interop's, hence it cannot be fed to the
Dispatcherclass.Promotion of
psr/containerto regular dependencyThe
Dispatcherclass -which lives undersrc- depends on it, so I believe it should not be disguised as a development/suggested depedency (if it's not installed could break production code).Potential BC breaks?
Since release 1.2.0 of container-interop
Interop\Container\ContainerInterfaceextendsPsr\Container\ContainerInterface, so I understand that there should be none: interop containers are also psr-11 containers (but the inverse does not hold).About the removal of composer.lockWhen installing a dependency with composer the composer.lock file is ignored, and most PHP libraries keep it out of the repository because it is just dead weight.