This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Allow using zend-console to determine if a CLI env is in play #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates zfcampus#86 to fix zfcampus#98 by testing if the `Zend\Console\Console` class is present and, if so, using the return value of its `isConsole()` method to determine the current SAPI environment. This approach allows overriding the environment for purposes of unit testing incoming HTTP requests. If the class is not available, we fallback to the `PHP_SAPI` value.
weierophinney
added a commit
that referenced
this pull request
Nov 21, 2017
weierophinney
added a commit
that referenced
this pull request
Nov 21, 2017
Forward port #100 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates #86 to fix #98 by testing if the
Zend\Console\Consoleclass is present and, if so, using the return value of itsisConsole()method to determine the current SAPI environment. This approach allows overriding the environment for purposes of unit testing incoming HTTP requests.If the class is not available, we fallback to the
PHP_SAPIvalue.Fixes #98