Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

PHP 7.2 support #103

Merged
merged 5 commits into from
May 7, 2018
Merged

PHP 7.2 support #103

merged 5 commits into from
May 7, 2018

Conversation

michalbundyra
Copy link
Member

Resolves #102

@michalbundyra
Copy link
Member Author

PHP 7.2 lowest build failing - phpspec issue?

@weierophinney
Copy link
Member

PHP 7.2 lowest build failing - phpspec issue?

The problem is the set of dependencies used in PHPUnit 5.7. It pins to sebastian/comparator at ^1.2.4; however, that version reports incorrect information to prophecy under PHP 7.2. I tried pinning to ^2.0, but PHPUnit 5.7 cannot use that series.

Interestingly, I only see this issue when attempting to mock the ServiceManager. More interestingly: the one test where we do so does not need to, as it can mock the PSR-11 ContainerInterface instead. In fact, when doing so, all testing issues go away.

I'll push the relevant change to your branch in a moment so that Travis can validate this observation.

michalbundyra and others added 5 commits May 7, 2018 14:40
@michalbundyra @weierophinney
Results of running zf-maintainer rebase-doc-templates
38f3b53
@michalbundyra @weierophinney
Updated Travis CI configuration
c9cd707 
- added 7.2 builds
- removed HHVM builds
- updated legacy deps
- removed IRC notifications
@michalbundyra @weierophinney
Updated dependencies
eb8a527 
- PHPUnit 5, 6 and 7 + config
- zend-coding-standard + config + cs fixes
- zendframework/zend-mvc to v2.7.15 || ^3.0.4
@michalbundyra @weierophinney
Added CHANGELOG for #103
ce1af30
@weierophinney
Mock the PSR-11 ContainerInterface instead of ServiceManager
7330d4e 
Removes the problems with mocking we observed when using PHP 7.2 and
PHPUnit 5.7.
@weierophinney weierophinney merged commit 7330d4e into zfcampus:develop May 7, 2018
weierophinney added a commit that referenced this pull request May 7, 2018
@weierophinney
Merge branch 'feature/103-php-7.2-support' into develop
3f1af8c 
Close #103
Fixes #102
@weierophinney
Copy link
Member

Thanks, @webimpress!

@michalbundyra michalbundyra deleted the feature/php-7.2-support branch May 8, 2018 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalbundyra @weierophinney