This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Allow application/hal+json on incoming requests. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I read [this issue](zfcampus/zf-apigility#114 (comment)) on HAL formatted data in incoming requests and think this PR contains all that is needed, but please have a critical look before merging. I also see further chances to improve this class so we can think about implementing different content-types for future support of XML requests etc. An idea would to add a method `getBodyParamsFromRequest` and move all the content type checking, decoding and parsing inside this method.
weierophinney
added a commit
that referenced
this pull request
May 26, 2016
Allow application/hal+json on incoming requests.
weierophinney
added a commit
that referenced
this pull request
May 26, 2016
Adds a test for #50, and fixes CS issues.
weierophinney
added a commit
that referenced
this pull request
May 26, 2016
weierophinney
added a commit
that referenced
this pull request
May 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read this issue on HAL formatted data in incoming requests and think this PR contains all that is needed, but please have a critical look before merging.
I also see further chances to improve this class so we can think about implementing different content-types for future support of XML requests etc. An idea would to add a method
getBodyParamsFromRequestand move all the content type checking, decoding and parsing inside this method.