-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Info for Errata #3 #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems very clear overall, and seems to me like a pretty easy mitigation!
Two nits noted.
msg/ZFS-8000-ER/index.html
Outdated
</dd> | ||
<dt><p><b>Suggested Action for System Administrator</b> | ||
<dd> | ||
Affected pools will need to recreate any encrypted datasets created before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean "System administrators with affected pools will need to ..."
msg/ZFS-8000-ER/index.html
Outdated
<dt><p><b>Severity</b> | ||
<dd>Moderate | ||
<dt><p><b>Description</b> | ||
<dd>The ZFS packages were updated after creating an encrypted dataset which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why specify "The ZFS packages were updated after..." here?
I think I understand what you mean - the buggy version of ZFS wouldn't emit this message. I think it would be clearer to say "An encrypted dataset contains an on-disk format incompatability", but maybe I'm missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose this wording to match the other errata. I can change it.
574c99f
to
6f978bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
msg/ZFS-8000-ER/index.html
Outdated
<dd> | ||
Encrypted datasets created before the ZFS packages were updated cannot be | ||
mounted or opened for write. The errata impacts the ability of ZFS to correctly | ||
perform raw sends, so these have been disabled for these datasets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/so these have been/so this functionality has been/
msg/ZFS-8000-ER/index.html
Outdated
state: ONLINE | ||
status: Errata #3 detected. | ||
action: To correct the issue revert to an earlier version and backup | ||
and destroy any existing encrypted datasets before updating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The action described here doesn't jibe with the recovery procedure outlined below. There is no need to rollback to a previous version of software unless you need to continue to mount the filesystems read/write.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. That's old. I'll update it
Signed-off-by: Tom Caputi <tcaputi@datto.com>
6f978bb
to
6c66084
Compare
See zfsonlinux issue openzfs/zfs#6845
Signed-off-by: Tom Caputi tcaputi@datto.com