Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Info for Errata #3 #35

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Conversation

tcaputi
Copy link

@tcaputi tcaputi commented Nov 13, 2017

See zfsonlinux issue openzfs/zfs#6845

Signed-off-by: Tom Caputi tcaputi@datto.com

Copy link
Contributor

@ofaaland ofaaland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very clear overall, and seems to me like a pretty easy mitigation!

Two nits noted.

</dd>
<dt><p><b>Suggested Action for System Administrator</b>
<dd>
Affected pools will need to recreate any encrypted datasets created before
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean "System administrators with affected pools will need to ..."

<dt><p><b>Severity</b>
<dd>Moderate
<dt><p><b>Description</b>
<dd>The ZFS packages were updated after creating an encrypted dataset which
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why specify "The ZFS packages were updated after..." here?

I think I understand what you mean - the buggy version of ZFS wouldn't emit this message. I think it would be clearer to say "An encrypted dataset contains an on-disk format incompatability", but maybe I'm missing something.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose this wording to match the other errata. I can change it.

Copy link
Member

@gmelikov gmelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

<dd>
Encrypted datasets created before the ZFS packages were updated cannot be
mounted or opened for write. The errata impacts the ability of ZFS to correctly
perform raw sends, so these have been disabled for these datasets.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/so these have been/so this functionality has been/

state: ONLINE
status: Errata #3 detected.
action: To correct the issue revert to an earlier version and backup
and destroy any existing encrypted datasets before updating.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action described here doesn't jibe with the recovery procedure outlined below. There is no need to rollback to a previous version of software unless you need to continue to mount the filesystems read/write.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. That's old. I'll update it

Signed-off-by: Tom Caputi <tcaputi@datto.com>
@behlendorf behlendorf merged commit 587f96a into zfsonlinux:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants