flake: fix patch for nix-eval-jobs #256
Conversation
zhaofengli
force-pushed
the
pks-nix-eval-job-fix-patch
branch
from
ed38ef0 to
5b124f7
Compare
|
Thanks! |
Head branch was pushed to by a user without write access
zhaofengli
force-pushed
the
pks-nix-eval-job-fix-patch
branch
from
50a13db to
a0caac4
Compare
The `writeReferencesToFile` builder has been removed in favor of `writeClosure` in 51da8b6b00c2 (writeReferencesToFile: remove, 2024-11-17). Adapt the code accordingly.
zhaofengli
force-pushed
the
pks-nix-eval-job-fix-patch
branch
from
a0caac4 to
c9e5689
Compare
|
(Sorry, missed your Will need to fix the Cargo flake tests later - Will merge as long as the integration tests pass. |
|
Hm. I don't get why the Linux test keeps failing. It passes on my machine 🤔 |
No worries :) Thanks for fixing up, didn't have the time yesterday when creating the MR to bring it over the finishing line.
Ok. 👍 |
It fails on newer Nix versions (not pinned by the devShell, regrettably). |
We carry a custom patch for nix-eval-jobs that causes the tool to not unset the `NIX_PATH` environment variable anymore. The patch does not apply anymore starting with d0bcdae (clang-tidy: use trailing return type, 2024-11-10) because surrounding code has changed. Other than that the patch still applies. The mentioned commit was released with nix-eval-jobs v2.25.0, which nixos-unstable has recently upgraded to. Adapt the patch to unbreak the build. Fixes zhaofengli#255.
|
Pushed another fix to make this work with older nixpkgs. |
Head branch was pushed to by a user without write access
pks-t
force-pushed
the
pks-nix-eval-job-fix-patch
branch
from
c9e5689 to
caabefa
Compare
|
Sorry for the late reply, let's merge this now and fix the remaining issues later. |
We carry a custom patch for nix-eval-jobs that causes the tool to not unset the
NIX_PATHenvironment variable anymore. The patch does not apply anymore starting with d0bcdae (clang-tidy: use trailing return type, 2024-11-10) because surrounding code has changed. Other than that the patch still applies.The mentioned commit was released with nix-eval-jobs v2.25.0, which nixos-unstable has recently upgraded to. Adapt the patch to unbreak the build.
Fixes #255.