Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid fen #98

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Invalid fen #98

merged 7 commits into from
Jun 7, 2022

Conversation

kieferro
Copy link
Contributor

@kieferro kieferro commented Jun 3, 2022

Fixes #97

Changes

If the Stockfish process crashes because of an invalid FEN or for some other reason, an error message is raised. I also added a test case for unittesting and an entry in the README.

@kieferro kieferro marked this pull request as ready for review June 3, 2022 19:48
Copy link
Owner

@zhelyabuzhsky zhelyabuzhsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Let's make some improvements.

stockfish/models.py Outdated Show resolved Hide resolved
@kieferro kieferro requested a review from zhelyabuzhsky June 7, 2022 11:56
Copy link
Owner

@zhelyabuzhsky zhelyabuzhsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

@zhelyabuzhsky zhelyabuzhsky merged commit 8b09683 into zhelyabuzhsky:master Jun 7, 2022
@kieferro kieferro deleted the invalid-fen branch June 7, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stockfish crashes on invalid position instead of error mesasge
2 participants