[sonic-yang-mgmt]: Move yang models to src/sonic-yang-models and build infra changes. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you describe the difference from this PR than the old yang models? Are you just moving the location or you have new changes? please include the removing action in the PR if just move location. If you have other changes, I would prefer to have another on top of it. |
|
First, commit just moves [copies] same yang models from old location to this location.
Second commit has new build infra for the sonic-yang-models package.
Thanks,
Regards
Praveen
…________________________________
From: zhenggen-xu <notifications@github.com>
Sent: Tuesday, February 25, 2020 8:44 PM
To: zhenggen-xu/sonic-buildimage <sonic-buildimage@noreply.github.com>
Cc: Praveen Chaudhary <pchaudhary@linkedin.com>; Author <author@noreply.github.com>
Subject: Re: [zhenggen-xu/sonic-buildimage] [sonic-yang-models]: First version of yang models for Sonic. (#54)
Can you describe the difference from this PR than the old yang models? Are you just moving the location or you have new changes? please include the removing action in the PR if just move location. If you have other changes, I would prefer to have another on top of it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzhenggen-xu%2Fsonic-buildimage%2Fpull%2F54%3Femail_source%3Dnotifications%26email_token%3DAJHZHPKXNM2N36LDBQLRRRLREXXSXA5CNFSM4K2USP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM6YWSA%23issuecomment-591235912&data=02%7C01%7Cpchaudhary%40linkedin.com%7C5864e0f178394826ebc608d7ba769284%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637182890738235134&sdata=7QBYqln%2F2IcuvhT%2FHGTlQly25tvoFtGC2ttPu7YSyvA%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJHZHPLYK2RO3GIPAVCSQRDREXXSXANCNFSM4K2USP6A&data=02%7C01%7Cpchaudhary%40linkedin.com%7C5864e0f178394826ebc608d7ba769284%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637182890738245093&sdata=DfZxTe4z8QcVIJJaLKbkEgr6S08aGyycRnYAleYR%2FK4%3D&reserved=0>.
|
|
I see commit 2 has same code but different location from old code. Please in this same PR, remove the old code, then add the new code. If any new changes like pip3 support, we should have a separate PR for now so it is easy to review. For upstream, since it is not merged yet, everything can go with one PR if you see fit. |
praveen-li
changed the title
|
@praveen-li Can you build an image with this change and load it on the box and try some of the system level functions? |
li-pingmao
reviewed
Mar 9, 2020
|
please resolve the conflicts and include the test results for the image with this PR. |
praveen-li
force-pushed
the
sonicYang
branch
4 times, most recently
from
c78d2f4
to
fe3c020
Compare
added 8 commits
April 7, 2020 16:23
…d infra changes. 1.) Move yang models to src/sonic-yang-models. 2.) New build infra for src/sonic-yang-models. 3.) Change in build infra for src/sonic-yang-mgmt. 4.) Makefile changes to make sonic-yang-mgmt depend on sonic-yang-models. 5.) Test files changes.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Changes: -- Reverting back to PY2. -- Keeping package environment varible name to SONIC_YANG_MGMT_PY Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
|
Test results on sonic image [latest DPB code + this PR]: [Please try to approve and merge fast, I want to raise new PRs on this new location, also I want to keep MSFT PRs similar to this.]. Thx. Testing with sonic image build with sonicYang branch. Check PKGs are installed on sonic image: Run bbreakout |
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
zhenggen-xu
approved these changes
Apr 8, 2020
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (zhenggen-xu#55) a1142e251 [sonic_operators.cpp] Update sonic_db_manager::get_counter (zhenggen-xu#56) 1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (zhenggen-xu#54) Signed-off-by: Ze Gan <ganze718@gmail.com>
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Dec 23, 2022
[202012][sonic-linkmgrd]Submodule update 8507629 Jing Zhang Mon Apr 4 10:25:22 2022 -0700 Lower unsolicited MUX state change notification log level to WARNING zhenggen-xu#57 17d217d Longxiang Lyu Mon Mar 21 12:15:19 2022 +0800 Enhance clang format (zhenggen-xu#46) c72fa2a Jing Zhang Fri Apr 1 12:23:29 2022 -0700 Disable the feature that decreases link probe interval for measuring switch overhead zhenggen-xu#49 (zhenggen-xu#54) 256b01b Jing Zhang Thu Mar 31 16:20:00 2022 -0700 Update link prober metrics posting logics zhenggen-xu#50 zhenggen-xu#53 dfd48d0 Jing Zhang Wed Mar 23 16:27:45 2022 -0700 Decrease link probing interval after switchover to better determine the overhead of a toggle zhenggen-xu#43 (zhenggen-xu#48) sign-off: Jing Zhang zhangjing@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
[sonic-yang-mgmt]: Move yang models to src/sonic-yang-models and build infra changes.
- How I did it
Wrote yang models based on Guideline doc:
https://github.com/Azure/SONiC/blob/master/doc/mgmt/SONiC_YANG_Model_Guidelines.md
and
https://github.com/Azure/SONiC/wiki/Configuration.
Wrote python wheel Package infra which runs test for these Yang models using a json files which consists configuration as per yang models. These configs are for negative tests, which means we want to test that must conditions, patterns and when conditions works as expected.
- How to verify it
Wrote python wheel Package infra which runs test for these Yang models using a json files which consists configuration as per yang models. These configs are for negative tests, which means we want to test that must conditions, patterns and when conditions works as expected.
Build Logs:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)