Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default_config_db.json for DPB system test #79

Merged
merged 3 commits into from
Jun 26, 2020

Conversation

vasant17
Copy link
Collaborator

- What I did
Added default_config_db.json file and updated Docker file Jinja template to to copy the file to /etc/sonic directory of vs container
- How I did it
Manually created the default config file.
- How to verify it
By creating VS container and ensuring that default config file is copied to the correct directory in container.
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@zhenggen-xu zhenggen-xu requested a review from praveen-li June 23, 2020 21:45
@@ -130,6 +130,7 @@ COPY ["files/configdb-load.sh", "/usr/bin/"]
COPY ["files/arp_update", "/usr/bin/"]
COPY ["files/buffers_config.j2", "files/qos_config.j2", "/usr/share/sonic/templates/"]
COPY ["files/sonic_version.yml", "/etc/sonic/"]
COPY ["default_config_db.json", "/etc/sonic/"]
Copy link
Owner

@zhenggen-xu zhenggen-xu Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praveen-li @praveen-li Did we agree to change this file name to something more obvious for user? I think it would be better to change the name to avoid confusion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about 'port_breakout_config_db.json'. I will change in Dev Code as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to "port_breakout_config_db.json"

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, go ahead with this new name.

Copy link
Collaborator

@praveen-li praveen-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VLAN_INTERFACE table and VLAN table does not have a port-related config. We can avoid them.
Keeping them is harmless. But it is better to keep only relevant config in this file. So that we can show this as an example to NetOps.
If possible, please address this.

"scope": "global"
}
},
"VLAN_INTERFACE": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VLAN_INTERFACE table and VLAN table does not have a port-related config. We can avoid them.
Keeping them is harmless. But it is better to keep only relevant config in this file. So that we can show this as an example to NetOps.

@vasant17 vasant17 merged commit 2a2705a into zhenggen-xu:sonic-cfg-mgmt Jun 26, 2020
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Aug 12, 2020
…nic-net#5103)

* src/sonic-platform-common be1cc24...f3f3573 (3):
  > Remove sonic-config-engine dependency from setup.py (sonic-net#109)
  > Migrate from sonic-daemon-base package to sonic-py-common package (sonic-net#103)
  > [Cables] Add support for 'Extended Specification Compliance' for QSFP cables (sonic-net#108)
  > [sfputilbase.py] Add application_advertisement NA field to transceiver_info_dict for platform api 1.0 (sonic-net#104)

* src/sonic-platform-daemons 49d145c...8e0704e (1):
  > Proper fix for thermalctld using sonic-py-common (zhenggen-xu#80)
  > Fix thermalctld tests which were broken by the transition to sonic-py-common (zhenggen-xu#79)
  > Migrate from sonic-daemon-base package to sonic-py-common package (zhenggen-xu#74)
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Aug 9, 2022
[sonic-linkmgrd][master] submodule updates

e7e00f2 Jing Zhang      Tue Jun 14 17:27:22 2022 -0700  Fix IP header checksum in handleSendSwitchCommand (zhenggen-xu#88)
127fd3d Jing Zhang      Tue Jun 7 09:33:03 2022 -0700   Check self's mux mode before switching peer to standby & add support for `detach` mode (zhenggen-xu#79)

sign-off: Jing Zhang zhangjing@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants