Gracefully handle empty "xstyle" prop values (Part 2) (facebook#23279)

facebook#23190 misses if entry is undefined or null. This fixes this issue.
zhengjitf · Apr 15, 2022 · 08ed325 · 08ed325
1 parent 6b0753e
commit 08ed325
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/react-devtools-shared/src/backend/StyleX/__tests__/utils-test.js b/packages/react-devtools-shared/src/backend/StyleX/__tests__/utils-test.js
@@ -54,6 +54,13 @@ describe('Stylex plugin utils', () => {
         "sources": Array [],
       }
     `);
+
+    expect(getStyleXData([undefined])).toMatchInlineSnapshot(`
+      Object {
+        "resolvedStyles": Object {},
+        "sources": Array [],
+      }
+    `);
   });
 
   it('should support simple style objects', () => {

diff --git a/packages/react-devtools-shared/src/backend/StyleX/utils.js b/packages/react-devtools-shared/src/backend/StyleX/utils.js
@@ -35,6 +35,10 @@ export function crawlData(
 
   if (isArray(data)) {
     data.forEach(entry => {
+      if (entry == null) {
+        return;
+      }
+
       if (isArray(entry)) {
         crawlData(entry, sources, resolvedStyles);
       } else {