Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comman table property to the sequencer class #268

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

tobiasah
Copy link
Member

Often a command table is associated with a specific sequencer code. This commit simplt adds a property as a "storage" in the sequencer class for a command table. There is no logic attached to this other then storing.

Description:

Fixes issue: #

Checklist:

  • Add tests for the change to show correct behavior.
  • Add or update relevant docs, code and examples.
  • Update CHANGELOG.rst with relevant information and add the issue number.
  • Add .. versionchanged:: where necessary.

@tobiasah tobiasah added the enhancement New feature or request label Oct 18, 2023
@tobiasah tobiasah self-assigned this Oct 18, 2023
@tobiasah tobiasah force-pushed the tobiasa/ct_to_seq branch 3 times, most recently from 9220a7c to 0f64d72 Compare October 19, 2023 05:56
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e082c54) 99.61% compared to head (0f64d72) 99.60%.

❗ Current head 0f64d72 differs from pull request most recent head 3a39c4f. Consider uploading reports for the commit 3a39c4f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   99.61%   99.60%   -0.01%     
==========================================
  Files          40       40              
  Lines        2567     2560       -7     
==========================================
- Hits         2557     2550       -7     
  Misses         10       10              
Files Coverage Δ
src/zhinst/toolkit/sequence.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_sequence.py Fixed Show fixed Hide fixed
Often a command table is associated with a specific sequencer
code. This commit simplt adds a property as a "storage" in the
sequencer class for a command table. There is no logic attached
to this other then storing.
@tobiasah tobiasah merged commit 9394cd7 into main Nov 2, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants