Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration length function argument for QA readout #273

Closed
wants to merge 1 commit into from

Conversation

ysalatheZI
Copy link
Collaborator

Description:

When using toolkit function device.qachannels[n].readout.write_integration_weights() sets the integration length to the length of integration weights by default. However, customers want to have the flexibility to set integration length independently.

The expected behavior is that users can set integration length independently.

We add an argument (integration_length) to the function above, and if the user does not configure it, by default the integration_length is equal to the number of integration weights (backwards compatible).

Needs corresponding update in zhinst-utils.

Fixes issue: #

Checklist:

  • Add tests for the change to show correct behavior.
  • Add or update relevant docs, code and examples.
  • Update CHANGELOG.rst with relevant information and add the issue number.
  • Add .. versionchanged:: where necessary.

@ysalatheZI ysalatheZI force-pushed the yvess/integration_length-GECKO-1168 branch from 56b7ee4 to 40dc248 Compare December 21, 2023 09:06
@tobiasah
Copy link
Member

tobiasah commented Jan 2, 2024

Before we merge this, we have to release a new zhinst-utils version that includes the counterpart of this change.
I do not thing that we need backward compatibility here, so apart from this it looks good to me

@tobiasah
Copy link
Member

closing this in favor of #274. The change is the same but #274 changes a view other things as well

@tobiasah tobiasah closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants