[llvm-jitlink] Use '@' rather than ':' for separator in -sectcreate.

This should avoid the issue with Windows paths that have caused failures on some builders.
zhiweij1 · Feb 20, 2024 · 54b014b · 54b014b
1 parent 39cab1a
commit 54b014b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/llvm/test/ExecutionEngine/JITLink/Generic/sectcreate.test b/llvm/test/ExecutionEngine/JITLink/Generic/sectcreate.test
@@ -1,6 +1,6 @@
 # RUN: llc -filetype=obj -o %t.o %S/Inputs/main-ret-0.ll
 # RUN: llvm-jitlink -noexec \
-# RUN:   -sectcreate __data,%S/Inputs/sectcreate-data.txt:foo=0 \
+# RUN:   -sectcreate __data,%S/Inputs/sectcreate-data.txt@foo=0 \
 # RUN:   %t.o
 #
 # Use -sectcreate to create a section from a data file.

diff --git a/llvm/tools/llvm-jitlink/llvm-jitlink.cpp b/llvm/tools/llvm-jitlink/llvm-jitlink.cpp
@@ -165,7 +165,7 @@ static cl::list<std::string>
 
 static cl::list<std::string>
     SectCreate("sectcreate",
-               cl::desc("given <sectname>,<filename>[:<sym>=<offset>,...]  "
+               cl::desc("given <sectname>,<filename>[@<sym>=<offset>,...]  "
                         "add the content of <filename> to <sectname>"),
                cl::cat(JITLinkCategory));
 
@@ -1683,7 +1683,7 @@ static Error addSectCreates(Session &S,
 
     StringRef SCArg(*SCItr);
 
-    auto [SectAndFileName, ExtraSymbolsString] = SCArg.split(':');
+    auto [SectAndFileName, ExtraSymbolsString] = SCArg.split('@');
     auto [SectName, FileName] = SectAndFileName.rsplit(',');
     if (SectName.empty())
       return make_error<StringError>("In -sectcreate=" + SCArg +