Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for unmanaged CPCs #374

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Support for unmanaged CPCs #374

merged 1 commit into from
Mar 29, 2023

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Mar 26, 2023

The main review point I think would be how the unmanaged CPCs are surfaced by the cli:

This PR introduces a new command group with a single command:

zhmc unmanaged_cpc list

The original proposal in issue #98 was to add the list command to the console command group:

zhmc console list-unmanaged-cpcs

@andy-maier andy-maier requested a review from EdGue42 March 26, 2023 12:38
@andy-maier andy-maier self-assigned this Mar 26, 2023
@andy-maier andy-maier added this to the 1.6.0 milestone Mar 26, 2023
@andy-maier andy-maier force-pushed the andy/add-unmanaged-cpcs branch from 9ef46ed to 003fc5c Compare March 26, 2023 12:39
@andy-maier andy-maier force-pushed the andy/add-unmanaged-cpcs branch 2 times, most recently from b4c5af4 to d94ea12 Compare March 26, 2023 14:09
@coveralls
Copy link

coveralls commented Mar 26, 2023

Coverage Status

Coverage: 31.679% (+0.05%) from 31.625% when pulling 0df62e4 on andy/add-unmanaged-cpcs into 259940b on master.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
@andy-maier andy-maier force-pushed the andy/add-unmanaged-cpcs branch from d94ea12 to 0df62e4 Compare March 26, 2023 17:03
@EdGue42 EdGue42 modified the milestones: 1.6.0, 1.7.0 Mar 27, 2023
Copy link
Contributor

@simon-spinner simon-spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That way we create a command group that doesn't correspond to an existing object on the WSAPI. I don't see it as an issue, because if the WSAPI would ever expose an operation for unmanaged CPCs, most probably it would introduce such an object as well.

@andy-maier andy-maier merged commit 992b05e into master Mar 29, 2023
@andy-maier andy-maier deleted the andy/add-unmanaged-cpcs branch March 29, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants