Fixup watch and example #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have much time to upgrade gun2.0 in the next 2 months, I would likely accept a PR that upgrade gun to 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return error in watch instead of hard pattern matching. And also enhance watch example codes.
Till now,
eetcdprovides a wrap over the watch API, but not a Watcher. There is still heavy work to do if users use thewatchAPI directly, like the example. Maybe providing a high-level watcher API would be better.By the way, @zhongwencool do you have any plan to upgrade
gunfrom 1.3 to 2.0, which provided much more robust error handlings and closer to the HTTP2 specification.