Suport auto-sync member list for an etcd conn instance #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbertwong96
suggested changes
Jan 19, 2022
belltoy
force-pushed
the
feature/auto-sync-memberlist
branch
from
b60dc7a to
f0b5ec8
Compare
gilbertwong96
added a commit
to gilbertwong96/eetcd
that referenced
this pull request
Aug 9, 2022
The tuple `Freeze` is different from the `Members`, which is the root cause why reconnect mechanism out of work in `connect_all` mode. This bug is introduced in zhongwencool#41.
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impl uses
auto_sync_interval_msoption to enabled (disabled default) auto sync member list via etcd v3 API. And also note, the auto_sync only works withconnect_allmode.This feature has been tested for etcd node restarts, member removed/added, add new learner members, promoted learners scenarios.