Update review feedback

zhongwuzw · Jan 9, 2024 · 8dc0647 · 8dc0647
1 parent 005a88d
commit 8dc0647
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/...act-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm b/...act-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm
@@ -278,9 +278,20 @@ id convertJSIValueToObjCObject(jsi::Runtime &runtime, const jsi::Value &value, s
                 }
                 return;
               }
-              reject->call([message](jsi::Runtime &rt, jsi::Function &jsFunction) {
-                jsFunction.call(
-                    rt, createJSRuntimeError(rt, [message ?: @"Unknown error from a native module" UTF8String]));
+
+              NSDictionary *jsErrorDetails = RCTJSErrorFromCodeMessageAndNSError(code, message, error);
+              reject->call([jsErrorDetails](jsi::Runtime &rt, jsi::Function &jsFunction) {
+                // From JS documentation:
+                // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Error#cause an
+                // Error can be created with `new Error(message, option);`. the `option` param is a JS object with the
+                // `cause` property. Create a valid `option` object
+                NSDictionary<NSString *, id> *jsErrorOptions = @{@"cause" : jsErrorDetails};
+                auto jsiObjCError = convertObjCObjectToJSIValue(rt, jsErrorOptions);
+                NSString *message =
+                    jsErrorDetails[@"message"] ? jsErrorDetails[@"message"] : @"Unknown error from a native module";
+                auto jsError =
+                    rt.global().getPropertyAsFunction(rt, "Error").call(rt, [message UTF8String], jsiObjCError);
+                jsFunction.call(rt, jsError);
               });
               resolveWasCalled = NO;
               resolve = std::nullopt;