fix: sort overseas countries by pinyin

also emit 中国 from oversea list fix #1
zhuangya · Apr 27, 2015 · fa4bc5e · fa4bc5e
1 parent 402f4ae
commit fa4bc5e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/lib/citydata.json b/lib/citydata.json
diff --git a/lib/update.js b/lib/update.js
@@ -1,5 +1,6 @@
 var restler = require('restler');
 var cheerio = require('cheerio');
+var pinyinSort = require('sort-by-pinyin');
 
 
 exports.update = function(){
@@ -28,9 +29,14 @@ exports.update = function(){
 					return;
 				}
 
+				overseasRawData = pinyinSort(overseasRawData);
+
 				console.log('mixing overseas data to city data...');
 				var overseasObj = {name:'海外'};
-				overseasObj.children = overseasRawData.map(function(item){
+				overseasObj.children = overseasRawData.filter(function (item) {
+					if (item === '中国') return false;
+					return true;
+				}).map(function(item){
 					return {
 						name:item
 					};
@@ -151,4 +157,4 @@ function getOverseasRawData(url,callback){
 	}).on('fail',function(){
 		callback(new Error('fail'));
 	}).on('error',callback);
-}
+}
diff --git a/package.json b/package.json
@@ -13,7 +13,8 @@
   "dependencies": {
     "cheerio": "^0.17.0",
     "commander": "~2.2.0",
-    "restler": "^3.2.2"
+    "restler": "^3.2.2",
+    "sort-by-pinyin": "^0.1.3"
   },
   "devDependencies": {},
   "main": "index.js",