fix(pipeline): unintended mutation in tool call IDs

zhudotexe · Oct 3, 2024 · 50f0525 · 50f0525
1 parent 2904d0d
commit 50f0525
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/kani/engines/huggingface/base.py b/kani/engines/huggingface/base.py
@@ -202,7 +202,6 @@ def build_prompt(
             raise NotImplementedError(
                 "You must pass a prompt_pipeline to the HuggingEngine to use it as a non-abstract class."
             )
-        log.debug(messages)  # todo temp
         prompt = self.pipeline(messages, functions)
         log.debug(f"BUILT PROMPT: {prompt}")
         return prompt

diff --git a/kani/prompts/steps.py b/kani/prompts/steps.py
@@ -259,8 +259,8 @@ def execute(self, msgs: list[PipelineMsgT], functions: list[AIFunction]) -> list
             # translate the id(s) if needed
             if self.id_translator is not None:
                 if m.tool_calls is not None:
-                    for tc in m.tool_calls:
-                        tc.id = self.id_translator(tc.id)
+                    # copy the tool calls here to prevent unintended mutation
+                    m.tool_calls = [tc.copy_with(id=self.id_translator(tc.id)) for tc in m.tool_calls]
                 if m.tool_call_id is not None:
                     m.tool_call_id = self.id_translator(m.tool_call_id)