Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poc: refactor retry settings into beans #8

Closed
wants to merge 1 commit into from
Closed

poc: refactor retry settings into beans #8

wants to merge 1 commit into from

Conversation

emmileaf
Copy link
Collaborator

@emmileaf emmileaf commented Dec 8, 2022 •
edited
Loading

Per discussion offline and in GoogleCloudPlatform/spring-cloud-gcp#1364

(I initially branched off the multi-module-w-shared, but this PR also contains the small change made to have languageSettings as its own bean.)

@emmileaf emmileaf marked this pull request as ready for review December 8, 2022 14:20
@emmileaf emmileaf requested a review from zhumin8 December 8, 2022 14:21
@emmileaf
Copy link
Collaborator Author

emmileaf commented Dec 8, 2022

Closing and will be combining this change with #6 - the missing piece here is still needing a Retry class that wraps around RetrySettings and makes the pieces configurable through spring properties.

@emmileaf emmileaf closed this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhumin8 zhumin8 Awaiting requested review from zhumin8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emmileaf